Add test that shows slicing breaks cam geom and fix it #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 10, 2018
kosack
approved these changes
Sep 21, 2018
kosack
requested changes
Sep 21, 2018
Codecov Report
@@ Coverage Diff @@
## master #782 +/- ##
==========================================
+ Coverage 71.92% 71.93% +0.01%
==========================================
Files 204 204
Lines 11056 11061 +5
==========================================
+ Hits 7952 7957 +5
Misses 3104 3104
Continue to review full report at Codecov.
|
kosack
approved these changes
Oct 9, 2018
|
merge? We just went into this again. |
kosack
requested changes
Oct 11, 2018
| @@ -6,6 +6,8 @@ | |||
| _get_min_pixel_seperation, | |||
| ) | |||
| import pytest | |||
| from ctapipe.io.eventsourcefactory import EventSourceFactory | |||
| from ctapipe.utils import get_dataset_path | |||
There was a problem hiding this comment.
is get_dataset_path or EventSourceFactory used anywhere in this test? Otherwise remove it
maxnoe
force-pushed
the
fix_cam_rotation
branch
from
dcb2407 to
f563076
Compare
maxnoe
force-pushed
the
fix_cam_rotation
branch
from
f563076 to
9d43744
Compare
|
done |
Closed
kosack
approved these changes
Oct 24, 2018
watsonjj
added a commit
to watsonjj/ctapipe
that referenced
this pull request
Nov 9, 2018
* master: (60 commits) Add test that shows slicing breaks cam geom and fix it (cta-observatory#782) fix ctapipe build failure (cta-observatory#811) fix package name for yaml (should be pyyaml) (cta-observatory#810) Implement number of islands (cta-observatory#801) fixed ranges of cam-display so they correspond to fixed toymodel sims (cta-observatory#808) Fix unknown section example warning (cta-observatory#800) Fix timing parameters for case when there are negative values in image (cta-observatory#804) Update Timing Parameters (cta-observatory#799) speed up unit tests that use test_event fixture (cta-observatory#798) Add unit to h_max in HillasReconstructor (cta-observatory#797) Codacy code style improvements (cta-observatory#796) Minor changes: mostly deprecationwarning fixes (cta-observatory#787) Array plotting (cta-observatory#784) added a config file for github change-drafter plugin (cta-observatory#795) Simple HESS adaptations (cta-observatory#794) add test for sliced geometries for hillas calculation (cta-observatory#781) Impact intersection (cta-observatory#778) updated main documentation page (cta-observatory#792) Implement concentration image features (cta-observatory#791) Fix bad builds by changing channel name (missing pyqt package) (cta-observatory#793) ... # Conflicts: # ctapipe/calib/camera/dl1.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.