Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leakage #783

Merged
merged 4 commits into from
Sep 21, 2018
Merged

Leakage #783

merged 4 commits into from
Sep 21, 2018

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Sep 10, 2018

Follow up to #775, using numpy

@maxnoe maxnoe requested review from kbruegge and kosack September 10, 2018 12:47
@codecov
Copy link

codecov bot commented Sep 10, 2018

Codecov Report

Merging #783 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #783      +/-   ##
=========================================
+ Coverage   71.54%   71.7%   +0.15%     
=========================================
  Files         199     201       +2     
  Lines       10824   10885      +61     
=========================================
+ Hits         7744    7805      +61     
  Misses       3080    3080
Impacted Files Coverage Δ
ctapipe/image/__init__.py 100% <100%> (ø) ⬆️
ctapipe/image/tests/test_leakage.py 100% <100%> (ø)
ctapipe/instrument/camera.py 96.85% <100%> (+0.35%) ⬆️
ctapipe/instrument/tests/test_camera.py 100% <100%> (ø) ⬆️
ctapipe/image/leakage.py 100% <100%> (ø)
ctapipe/io/containers.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72d9b90...0909466. Read the comment docs.

@maxnoe
Copy link
Member Author

maxnoe commented Sep 10, 2018

borders

kosack
kosack approved these changes Sep 21, 2018
View reviewed changes
Copy link
Contributor

@kosack kosack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this PR replace #775 then? It looks like a cleaner implementation

@maxnoe
Copy link
Member Author

maxnoe commented Sep 21, 2018

Yes, that's the idea.

@kosack kosack mentioned this pull request Sep 21, 2018
Closed
@kosack
Copy link
Contributor

kosack commented Sep 21, 2018

Ok i'll close #775

@kosack kosack merged commit 20c74be into cta-observatory:master Sep 21, 2018
@maxnoe maxnoe deleted the leakage branch September 21, 2018 14:12
kosack added a commit that referenced this pull request Sep 21, 2018
@kosack
Revert "better leakage parameter calculation (#783)"
f59f5ca 
This reverts commit 20c74be.
kosack added a commit that referenced this pull request Sep 21, 2018
@kosack
Revert "Fixing core reconstruction" (#789)
603d1ab 
* Revert "better leakage parameter calculation (#783)"

This reverts commit 20c74be.

* Revert "Fixing core reconstruction (#777)"

This reverts commit 5d4cd37.
@maxnoe maxnoe mentioned this pull request Jan 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kosack kosack kosack approved these changes

@kbruegge kbruegge Awaiting requested review from kbruegge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxnoe @kosack