Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image truncation or leakage parameter missing? #695

Closed
rlopezcoto opened this issue Mar 28, 2018 · 4 comments
Closed

Image truncation or leakage parameter missing? #695

rlopezcoto opened this issue Mar 28, 2018 · 4 comments

Comments

@rlopezcoto
Copy link
Contributor

Hi,

I've been trying to find how truncated images are handled but could not find any parameter that is containing that information after the shower image analysis. Does anybody know where is this implemented or wether there is no implementation at all?

Thanks

@kosack
Copy link
Contributor

kosack commented Mar 28, 2018

Right now it has not yet been merged into the main ctapipe code -there are only some basic mathods in @tino-michael's repo, including edge-pixel rejection. If you'd like to help, its appreciated! It's not clear to me yet what method is best. The easiest of course is just putting a cut on the hillas centroid distance.

@rlopezcoto
Copy link
Contributor Author

Sorry, I could not find anything in any of the branches of the repo, @tino-michael could you point me to the modified files?

@tino-michael
Copy link
Contributor

It's not a branch in my ctapipe fork, it's in my ImageCleaning module in a separate repo:
https://github.com/tino-michael/tino_cta/blob/master/tino_cta/ImageCleaning.py

@maxnoe
Copy link
Member

maxnoe commented Jan 3, 2019

Got implemented in #783, function is ctapipe.image.leakage

@maxnoe maxnoe closed this as completed Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants