Change how DataWriter writes simulation pointing #2438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnoe
force-pushed
the
datawriter_pointing
branch
2 times, most recently
from
cbfb840 to
3bd23e4
Compare
maxnoe
force-pushed
the
datawriter_pointing
branch
from
3bd23e4 to
92d9f5f
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2438 +/- ##
==========================================
- Coverage 92.48% 92.46% -0.02%
==========================================
Files 234 234
Lines 19831 19846 +15
==========================================
+ Hits 18340 18350 +10
- Misses 1491 1496 +5 ☔ View full report in Codecov by Sentry. |
Tobychev
previously approved these changes
Nov 17, 2023
Instead of writing the unique pointings with their timestamp, which has no physical meaning in case of simulations, we now write the first pointing per observation block into the "/configuration/telescope/pointing/tel_nnn" tables.
maxnoe
force-pushed
the
datawriter_pointing
branch
from
92d9f5f to
89b84a4
Compare
Tobychev
approved these changes
Nov 28, 2023
kosack
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of writing the unique pointings with their timestamp, which has no physical meaning in case of simulations, we now write the first pointing per observation block into the "/configuration/telescope/pointing/tel_nnn" tables.
Fixes #1484 and #1562