Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store event-wise pointing at least for MC #1484

Closed
maxnoe opened this issue Oct 22, 2020 · 3 comments · Fixed by #2438
Closed

Store event-wise pointing at least for MC #1484

maxnoe opened this issue Oct 22, 2020 · 3 comments · Fixed by #2438

Comments

@maxnoe
Copy link
Member

maxnoe commented Oct 22, 2020

I think we should optionally enable storing dl1/event/telescope/pointing with TelEventIndex at least for simulations since
the timestamp based approach will not work for mcs since they are produced in parallel.
Alternatively, we should atleast include an obs_id in the monitoring table.

This will create problems when merging files that do not only contain a single pointing position.

@kosack
Copy link
Contributor

kosack commented Oct 23, 2020

what is obs_index? Is that obs_id? That would perhaps be better to store in the monitoring table along with the time, since then either could be used to link the dataset (in case the time is meaningless).

@maxnoe
Copy link
Member Author

maxnoe commented Oct 23, 2020

what is obs_index? Is that obs_id?

yes, sorry. fixed.

@kosack
Copy link
Contributor

kosack commented Nov 5, 2020

yes, at least adding an obs_id I think is useful. Eventwise pointing could be done too, but it's really overkill to have the pointing position per event when it changes on a much slower rate (once per second + interpolation to the event time is usually enough). So far simulations only have fixed alt/az - we will have to consider something better when and if we do ra/dec simulations. I had always assumed we'd just have a function that just provides event_wise pointing based on the monitoring data, like a PointingInterpolator. For MCs, this could just use the obs_id if we add it, and for observations, it would be a proper interpolation of the actual pointing monitoring data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants