Make ExpressionEngine be no Component. Fixes #2065. #2068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the (before duplicated) expressions from the provenance log. QualityQuery and FeatureGeneration 'expressions' are still available via their configs and provenance log.
maxnoe
approved these changes
Sep 7, 2022
Codecov Report
@@ Coverage Diff @@
## master #2068 +/- ##
==========================================
- Coverage 92.42% 92.41% -0.01%
==========================================
Files 197 197
Lines 16163 16159 -4
==========================================
- Hits 14939 14934 -5
- Misses 1224 1225 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kosack
approved these changes
Sep 7, 2022
LukasBeiske
pushed a commit
to LukasBeiske/ctapipe
that referenced
this pull request
Sep 8, 2022
…ta-observatory#2068) This removes the (before duplicated) expressions from the provenance log. QualityQuery and FeatureGeneration 'expressions' are still available via their configs and provenance log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the (before duplicated) expressions from the provenance log. QualityQuery and FeatureGeneration 'expressions' are still available via their configs and provenance log.