Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality Critieria are listed twice in the provenance log #2065

Closed
kosack opened this issue Sep 5, 2022 · 0 comments
Closed

Quality Critieria are listed twice in the provenance log #2065

kosack opened this issue Sep 5, 2022 · 0 comments
Labels

Comments

@kosack
Copy link
Contributor

kosack commented Sep 5, 2022

Describe the bug

Both the QualityQuery and its internal ExpressionEngine's criteria get written to the provenance log. It seems both return their configuration, but this is redundant info. This also means both are in principle configurable in a config file, which could be confusing: which gets precedence in case of both being used?

This is likely because ExpressionEngine inherits from Component: I don't think it should, it would be fine as a bare class since it is not a processing component.

Example:

              "ImageQualityQuery": {
                  "quality_criteria": [
                     [
                        "size_greater_0",
                        "image.sum() > 0"
                     ]
                  ],
                  "ExpressionEngine": {
                     "expressions": [
                        [
                           "size_greater_0",
                           "image.sum() > 0"
                        ]
                     ]
                  }
              }

To Reproduce

Check the provenance.log after running ctapipe-process.

Expected behavior

Only the configurable criteria should appear.

@kosack kosack added the bug label Sep 5, 2022
nbiederbeck added a commit that referenced this issue Sep 7, 2022
This removes the (before duplicated) expressions from the
provenance log. QualityQuery and FeatureGeneration 'expressions' are
still available via their configs and provenance log.
@kosack kosack closed this as completed in de1fb3b Sep 7, 2022
LukasBeiske pushed a commit to LukasBeiske/ctapipe that referenced this issue Sep 8, 2022
…ta-observatory#2068)

This removes the (before duplicated) expressions from the
provenance log. QualityQuery and FeatureGeneration 'expressions' are
still available via their configs and provenance log.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant