You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Both the QualityQuery and its internal ExpressionEngine's criteria get written to the provenance log. It seems both return their configuration, but this is redundant info. This also means both are in principle configurable in a config file, which could be confusing: which gets precedence in case of both being used?
This is likely because ExpressionEngine inherits from Component: I don't think it should, it would be fine as a bare class since it is not a processing component.
This removes the (before duplicated) expressions from the
provenance log. QualityQuery and FeatureGeneration 'expressions' are
still available via their configs and provenance log.
…ta-observatory#2068)
This removes the (before duplicated) expressions from the
provenance log. QualityQuery and FeatureGeneration 'expressions' are
still available via their configs and provenance log.
Describe the bug
Both the
QualityQuery
and its internalExpressionEngine
's criteria get written to the provenance log. It seems both return their configuration, but this is redundant info. This also means both are in principle configurable in a config file, which could be confusing: which gets precedence in case of both being used?This is likely because ExpressionEngine inherits from Component: I don't think it should, it would be fine as a bare class since it is not a processing component.
Example:
To Reproduce
Check the
provenance.log
after runningctapipe-process
.Expected behavior
Only the configurable criteria should appear.
The text was updated successfully, but these errors were encountered: