-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements One Call Api #306
Conversation
Somehow I can't run the integration tests locally.
But geojson is installed... @csparpa Do you have any idea? |
I've fixed the issue with geojson (it was due to Tox not being told to install it) I've also fixed a few integration tests but be aware that a few more are failing because they refer to locations/resources that are no longer availabile on the OWM API - they've actually been available for a while, then something changed on their side and we began getting 404s For the moment, just ignore those. |
Just wanted to thank you for the great job you've done! :) I've made these tiny changes:
There is only one thing missing now: a short user-level documentation to help people quickly get started with OneCalls in PyOWM I've written user-level docs for other PyOWM features ("code recipes") in the past and I ask if you're willing to do the same for the OneCall feature. https://github.com/csparpa/pyowm/tree/develop/sphinx/v3 and put the documentation there in plain Markdown syntax (you can take inspiration from the other files in that folder) Thanks, let me know if you can make it and any issues you might encounter |
Implements #301
@csparpa Please give it a look, I have change some parts of the weather.py
Also maybe you have some ideas to test it better.