Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OneCall docu and add more tests #307

Closed
edenhaus opened this issue Apr 26, 2020 · 4 comments
Closed

Add OneCall docu and add more tests #307

edenhaus opened this issue Apr 26, 2020 · 4 comments
Assignees

Comments

@edenhaus
Copy link
Contributor

See #306 (comment)

@csparpa You can assign this issue to me. It is better to have an issue as to comment on a merged pull request. This week is already full with uni and work, but I think I can do it next week.

@csparpa
Copy link
Owner

csparpa commented Apr 27, 2020

@edenhaus I've written tests for weather_manager.one_call and weather_manager.once_call_history functions

Up to you writing tests for the OneCall class then

@edenhaus
Copy link
Contributor Author

edenhaus commented Apr 28, 2020

@csparpa nice :) I have already written some basic unit tests in the original PR. As OneCall uses the weather class, I think this enough tests for the moment. So I will concentrate on the docs next week.

When will be version 3.0 released?

@csparpa
Copy link
Owner

csparpa commented Apr 28, 2020

There is no release date but I would love to release v3 as soon as possible so that people can start using the OneCall feature as a swap-in replacement for the dead DarkSky API

No need to hurry!

@edenhaus
Copy link
Contributor Author

Nice. I will then include the new version into home assistant as I will use oneCall to get the forecast for my smart irrigation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants