set status values to match what is currently in oCIS frontend.go #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-davis
force-pushed
the
set-matching-status-values
branch
from
03533c9
to
a228bc2
Compare
|
If this is approved then I will make a similar PR to master, so that this is a least consistent. |
phil-davis
force-pushed
the
set-matching-status-values
branch
from
a228bc2
to
07a2913
Compare
phil-davis
force-pushed
the
set-matching-status-values
branch
from
07a2913
to
4509a51
Compare
micbar
approved these changes
Feb 24, 2022
C0rby
approved these changes
Feb 24, 2022
26 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/owncloud/ocis/blob/master/storage/pkg/command/frontend.go currently has hard-coded values in capabilities core status that get returned in a capabilities response.
reva has 10.0.9.5 still in some places, but other places have 10.0.11.5
Make the hardcoded values for version, product name etc. the same - then at least they will be consistent for now.
There has been other mention of implementing some proper advertising of a product name and version of reva and oCIS using semver etc. That is a different issue, and can be sorted out after this PR gets the hard-coded values consistent.