Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different version, edition and productname in status request and capabilities request #2174

Closed
dpakach opened this issue Jun 14, 2021 · 1 comment
Labels

Comments

@dpakach
Copy link
Contributor

dpakach commented Jun 14, 2021

Describe the bug

When requesting the capabilities endpoint and the stauts.php endpoints, we get different values for version, edition and product name

Steps to reproduce

  1. On capabilities request
❯ curl https://localhost:9200/ocs/v2.php/cloud/capabilities -k -u admin:admin | xmllint --format -
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2480    0  2480    0     0  77500      0 --:--:-- --:--:-- --:--:-- 77500
<?xml version="1.0" encoding="UTF-8"?>
<ocs>
  <meta>
    <status>ok</status>
    <statuscode>200</statuscode>
    <message>OK</message>
  </meta>
  <data>
    <capabilities>
      <core>
        <pollinterval>60</pollinterval>
        <webdav-root>remote.php/webdav</webdav-root>
        <status>
          <installed>1</installed>
          <maintenance>0</maintenance>
          <needsDbUpgrade>0</needsDbUpgrade>
          <version>10.0.11.5</version>
          <versionstring>10.0.11</versionstring>
          <edition>community</edition>
          <productname>reva</productname>
        </status>
        <support-url-signing>1</support-url-signing>
      </core>
...
  </data>
</ocs>
  1. From status.php
❯ curl https://localhost:9200/status.php -k                                                       
{
    "installed": true,
    "maintenance": false,
    "needsDbUpgrade": false,
    "version": "10.0.9.5",
    "versionstring": "10.0.9",
    "edition": "community",
    "productname": "ownCloud"
}%   

Setup

Please describe how you started the server and provide a list of relevant environment variables.

OCIS_VERSION=git
BRANCH=master
STORAGE_FRONTEND_UPLOAD_DISABLE_TUS=false

Additional context

Add any other context about the problem here.

@phil-davis
Copy link
Contributor

Fixed with PR #3231 which pulled in cs3org/reva#2581 - the values now match each other.

There is a separate issue about actually advertising a changing version numb er, using semver etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants