Check if symlink exists instead of spamming the console #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butonic
force-pushed
the
remove_prints_for_spaces
branch
from
96cfcf4
to
c5c5cda
Compare
C0rby
suggested changes
Aug 13, 2021
Signed-off-by: Jörn Friedrich Dreyer <[email protected]> Update pkg/storage/utils/decomposedfs/tree/tree.go Co-authored-by: David Christofas <[email protected]> incorporate review Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic
force-pushed
the
remove_prints_for_spaces
branch
from
cafb6b8
to
e7c9a2e
Compare
labkode
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logs have been spammed with messages like
could not create symlink for ...when using the decomposedfs, eg. with the oCIS storage. We now check if the link exists before trying to create it.deprecates #1988