could not create symlink for 'personal' space

[wkloucek]

Describe the bug

While using oCIS 1.9.0-RC1 the log ouptut will be spammed with following message:

could not create symlink for 'personal' space 13a483b9-5b6c-4dec-a6aa-90eda42327e0, symlink ../../nodes/13a483b9-5b6c-4dec-a6aa-90eda42327e0 /var/tmp/ocis/storage/users/spaces/personal/13a483b9-5b6c-4dec-a6aa-90eda42327e0: file exists

Steps to reproduce

Steps to reproduce the behavior:

1. run oCIS 1.9.0-RC1 and move to all files and watch the server log

Expected behavior

No error logs

Actual behavior

A lot of error logs with the message above.

even when using the logger printing on a file, the terminal will be spammed with the print message

OCIS_LOG_FILE=/Users/test/logs/test.log ocis/bin/ocis server

[refs]

We found the culprit being this commit on Reva. Since that commit is associated with a beefy PR, there are 2 proposed remedies:

• be more thorough on code reviews
• enforce a golangci linter such as forbidgo

A rule like:

linters-settings:
  forbidigo:
    # Forbid the following identifiers (identifiers are written using regexp):
    forbid:
      - ^print.*$
      - 'fmt\.Print.*'
    # Exclude godoc examples from forbidigo checks.  Default is true.
    exclude_godoc_examples: false

should prevent such identifiers to make it to CI. It is, however, controversial.

[micbar]

ok decision with @butonic @dragotin

Not a release blocker.

only affects the decomposedfs.

[wkloucek]

fixed in cs3org/reva#1992