Fixes and updates #125
Merged
Fixes and updates #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
neelabhg
commented
Nov 12, 2015
neelabhg
commented
- Update dependencies
- Migrate to new Travis-CI infrastructure (Migrate to new Travis-CI infrastructure #117) and enable caching of dependencies
- Open license in a modal window instead of linking to GitHub (Add license into the webapp instead of linking to Github #123)
- Use HTTPS as much as possible (VM freezes after 'Booting' in Firefox with the HTTPS Everywhere extension enabled #111)
- Fix jquery-notific8 fonts in distribution version
The new container-based infrastructure allows quicker build startup times, faster builds, more available resources, faster network accesses, and most importantly the ability to cache dependencies for open source projects, which was previously only available for private repositories. See http://docs.travis-ci.com/user/migrating-from-legacy/ and http://docs.travis-ci.com/user/caching/. This commit resolves cs-education#117.
The "crockford" JSCS preset was updated with a new rule: "The var statement should be the first statement in the function body." We don't need this rule, so this rule has been overridden in .jscsrc. The grunt-contrib-connect plugin now uses connect 3, which moved middlewares to separate repositories. So now we need to use the serve-static middleware instead of connect.static.
…breakages videojs updated its `bower.json`'s `"main"` field to use ES6 and Sass files, which are incompatible with the way we inject dependencies. So I updated `bower.json` to override that config so that `grunt bowerInstall` can inject the dependencies correctly. Gemnasium (https://gemnasium.com/cs-education/sysbuild) reports that modernizr has latest version 3.2.0, but in fact the latest version is 2.8.3, which we already have. Currently there doesn't seems to be a way to ignore certain packages in Gemnasium, so we'll have to live with the "dependencies out-of-date" badge. This isn't so bad, because we are actually using an outdated version of typeahead.js. typeahead.js cannot be updated to the next major version (0.11.x), because it introduces breaking changes into its API. It'll take some effort to support the new API. So, we need to stick with 0.10.x versions. 0.10.5 is the latest version, which we already have.
Now `grunt bowerInstall` can be used to inject ace-build files into index.html
LICENSE.md is already bundled with the distribution. So, the license text is grabbed from the root of the dist/ folder. Because the LICENSE.md is not in the content root during development, the connect server configuration in Gruntfile.js had to be modified to handle the /LICENSE.md route. Closes cs-education#123
Fonts are now copied to /styles/fonts/, which is where jquery-notific8 looks for them. Removed the /styles/fonts/ directory from the grunt-rev config, to prevent renaming of font files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.