Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license into the webapp instead of linking to Github #123

Closed
neelabhg opened this issue Nov 11, 2015 · 0 comments
Closed

Add license into the webapp instead of linking to Github #123

neelabhg opened this issue Nov 11, 2015 · 0 comments

Comments

@neelabhg
Copy link
Member

Clicking on the copyright info in the footer currently opens the LICENSE file on GitHub in a new tab.

This could be modified to fetch the file and show it in a modal popup (similar to how Code Moo does it).

There are many advantages:

  • The user stays in the application (and the same tab), instead of being sent to GitHub, leading to a better user experience
  • The LICENSE file will be served from GitHub Pages instead of github.com:
    • GitHub Pages uses a CDN, so the file will be accessed faster and more efficiently
    • Opening github.com will unnecessarily download accompanying HTML, CSS and JS
  • The LICENSE file will be bundled with the application (so changes to the license do not affect the license used by the deployed application)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant