prioritize reference id in name resolution to avoid shadowing issues #2121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xalpharush
changed the title
|
another example of why it would make sense to rewrite a parser for solidity 0.8 only :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces #2060
fixes #2058
Prior to 0.5.0 (xref ethereum/solidity#1679), the scoping rules allow references to undeclared variables so shadowing a state variable in a function body would still prioritize the yet-declared local variable. Following 0.5.0, it is no longer possible to have forward references, and the reference will be to the state variable in the case that a shadowing local declaration is declared in predecessors of the same lexical scope.