[Bug]: State variables shadowed by a local variable are incorrectly set to the local variable

[Tiko7454]

Describe the issue:

A state variable is used before it was shadowed. The dependency goes to the local variable instead of state variable

Code example to reproduce the issue:

// SPDX-License-Identifier: UNLICENSED

pragma solidity 0.8.7;

contract B {
    uint public x = 21;
    function a()  public {
        uint u = 2 * x;  // BUG
        uint x;
    }
}

> from slither import Slither
>
>
> a = Slither('b.sol').contracts[0].functions[0]
> buggy_node = a.nodes[1]
> print(buggy_node.variables_read[0].canonical_name)
>> B.a().x

Version:

0.9.3
(tested the freshest dev branch 3e39026)

Relevant log output:

No response

[smonicas]

The issue is in early expression parsing because x is found by this code as the local variable. Removing this code makes the example works however it will fail if the legacy ast is used and i'm not sure if there are other edge cases that require it.

slither/slither/solc_parsing/expressions/find_variable.py

Lines 83 to 86 in e5f2a86

	# If not found, check for name
	func_variables = function_parser.underlying_function.variables_as_dict
	if var_name in func_variables:
	return func_variables[var_name]

[0xalpharush]

Closed by #2121