Dominator deadcode problem fix #1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tiko7454
force-pushed
the
dominator-deadcode-problem-fix
branch
2 times, most recently
from
ab43894 to
d75d8d8
Compare
|
|
Tiko7454
force-pushed
the
dominator-deadcode-problem-fix
branch
from
3e2ed00 to
d75d8d8
Compare
Tiko7454
force-pushed
the
dominator-deadcode-problem-fix
branch
from
2de8ab5 to
cee0c6b
Compare
Tiko7454
force-pushed
the
dominator-deadcode-problem-fix
branch
from
8ae3ada to
7a35d8f
Compare
Tiko7454
force-pushed
the
dominator-deadcode-problem-fix
branch
from
2687867 to
0de7a25
Compare
smonicas
requested changes
Sep 8, 2023
Tiko7454
force-pushed
the
dominator-deadcode-problem-fix
branch
from
a15e1fc to
2687867
Compare
montyly
reviewed
Sep 15, 2023
|
|
||
| ret = set() | ||
| for pred in node.fathers: | ||
| ret = ret.union(pred.dominators) |
There was a problem hiding this comment.
Mhh I am confused, can you explain why are we doing the union over the predecessor dominators, and then their interaction?
It seem to me that this loop should be removed - unless I am missing something here
There was a problem hiding this comment.
It's the safest way to start set intersections. I could store the first set as the base and start intersecting all sets with that but the first set may not exist. So the safest way is to get every element from every set, and start to intersect every set with that big set
|
thanks @Tiko7454 |
This was referenced Oct 12, 2023
|
For visibility, there was an issue with the recent add of the vyper support (see #2171). We will investigate this further |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1973 the way I mentioned in the bug report