New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate Dominator deadcode problem fix #2171

Closed

montyly opened this issue Oct 13, 2023 · 1 comment

Member

montyly commented Oct 13, 2023

I had to revert #1984 in #2170, for the vyper test to pass. @0xalpharush : can you take a look at it?

I wanted to move fast to make the release today, so I did not investigate what was hapenning

montyly mentioned this issue

Dominator deadcode problem fix #1984

Merged

Contributor

0xalpharush commented Oct 13, 2023

We need to mirror the calls to update_reachability and set_reachable in the cfg parsing for Vyper also. The original PR only implemented it for solc

0xalpharush mentioned this issue

update vyper cfg to include reachability #2182

Merged

0xalpharush closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment