Fix naming-convention
to flag single letter O
or I
variable
#1470
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex
^[lOI]$
insideshould_avoid_name()
will only match on the single letter variablesl
,O
, orI
, which are not recommended by the style guide.The inner
not is_upper_case_with_underscores()
check is unnecessary and also allows the single letter variablesO
andI
to pass.Fixes #1418