Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix naming-convention to flag single letter O or I variable #1470

Merged
merged 3 commits into from
Dec 20, 2022
Merged

Fix naming-convention to flag single letter O or I variable #1470

merged 3 commits into from
Dec 20, 2022

Conversation

ardislu
Copy link
Contributor

@ardislu ardislu commented Nov 15, 2022

The regex ^[lOI]$ inside should_avoid_name() will only match on the single letter variables l, O, or I, which are not recommended by the style guide.

The inner not is_upper_case_with_underscores() check is unnecessary and also allows the single letter variables O and I to pass.

Fixes #1418

@CLAassistant
Copy link

CLAassistant commented Nov 15, 2022

CLA assistant check
All committers have signed the CLA.

@montyly
Copy link
Member

montyly commented Dec 20, 2022

great fix @ardislu. Thanks for updating the tests ;)

@montyly montyly merged commit 696b42e into crytic:dev Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants