naming-convention does not flag I or O variable

[elopez]

Describe the issue:

Slither has a detection for usage of

• l - Lowercase letter el
• O - Uppercase letter oh
• I - Uppercase letter eye

https://docs.soliditylang.org/en/v0.8.17/style-guide.html#names-to-avoid

However this detection fails on O and I, as the code considers them "uppercase with underscores" even though there are no underscores.

Relevant code:

• slither/slither/detectors/naming_convention/naming_convention.py

  Lines 52 to 54 in fba37f2

  	@staticmethod
  	def is_upper_case_with_underscores(name):
  	return re.search("^[A-Z0-9_]+_?$", name) is not None

  (will match just uppercase letters as well)

• slither/slither/detectors/naming_convention/naming_convention.py

  Lines 120 to 137 in fba37f2

  	for var in contract.state_variables_declared:
  	if self.should_avoid_name(var.name):
  	if not self.is_upper_case_with_underscores(var.name):
  	info = [
  	"Variable ",
  	var,
  	" used l, O, I, which should not be used\n",
  	]
  	res = self.generate_result(info)
  	res.add(
  	var,
  	{
  	"target": "variable",
  	"convention": "l_O_I_should_not_be_used",
  	},
  	)
  	results.append(res)

  (detection code)

Code example to reproduce the issue:

// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.0;

contract C {
    bool constant l = false;
    bool constant O = false;
    bool constant I = false;
    function f() public pure {}
}

Version:

0.9.0

Relevant log output:

No response

[webthethird]

Should this issue be closed? I'm cruising the open issue tracker for "good first issue" opportunities, and there are a few like this that appear to have been resolved (based on being mentioned in other issues/PRs)