Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve etherscan and brownie tests #342

Merged
merged 3 commits into from
Jan 6, 2023
Merged

Improve etherscan and brownie tests #342

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a7c56b
ci: etherscan: sleep briefly when the API key is not available
elopez Jan 5, 2023
30333e5
ci: pass GITHUB_TOKEN to tests
elopez Jan 5, 2023
3ea6558
ci: etherscan: de-randomize sleep
elopez Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ jobs:
env:
TEST_TYPE: ${{ matrix.type }}
GITHUB_ETHERSCAN: ${{ secrets.GITHUB_ETHERSCAN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
shell: bash
run: |
bash "scripts/ci_test_${TEST_TYPE}.sh"
23 changes: 20 additions & 3 deletions scripts/ci_test_etherscan.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,27 +7,44 @@ cd "$DIR" || exit 255

solc-select use 0.4.25 --always-install

delay_no_key () {
# Perform a small sleep when API key is not available (e.g. on PR CI from external contributor)
if [ "$GITHUB_ETHERSCAN" = "" ]; then
sleep $(( ( RANDOM % 5 ) + 1 ))s
elopez marked this conversation as resolved.
Show resolved Hide resolved
fi
}

echo "::group::Etherscan mainnet"
crytic-compile 0x7F37f78cBD74481E593F9C737776F7113d76B315 --compile-remove-metadata --etherscan-apikey "$GITHUB_ETHERSCAN"

if [ $? -ne 0 ]
then
echo "Etherscan test failed"
echo "Etherscan mainnet test failed"
exit 255
fi
echo "::endgroup::"

delay_no_key

echo "::group::Etherscan rinkeby"
crytic-compile rinkeby:0xFe05820C5A92D9bc906D4A46F662dbeba794d3b7 --compile-remove-metadata --etherscan-apikey "$GITHUB_ETHERSCAN"

if [ $? -ne 0 ]
then
echo "Etherscan test failed"
echo "Etherscan rinkeby test failed"
exit 255
fi
echo "::endgroup::"

delay_no_key

# From crytic/slither#1154
echo "::group::Etherscan #3"
crytic-compile 0xcfc1E0968CA08aEe88CbF664D4A1f8B881d90f37 --compile-remove-metadata --etherscan-apikey "$GITHUB_ETHERSCAN"

if [ $? -ne 0 ]
then
echo "Etherscan test failed"
echo "Etherscan #3 test failed"
exit 255
fi
echo "::endgroup::"