Improve etherscan and brownie tests #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elopez
force-pushed
the
dev-fix-etherscan-brownie
branch
from
93957e0 to
0a298ba
Compare
Etherscan performs a 1/5s rate limit when using no API key, so this adds a small random sleep to avoid the second test failing if it executes fast enough.
brownie sometimes fails on CI with the following message
ConnectionError: Status 403 when retrieving repo brownie-mix/token information from GHAPI: 'API rate limit exceeded for 40.77.45.130. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)'
This passes GITHUB_TOKEN onto the test environment to increase the rate limit.
elopez
force-pushed
the
dev-fix-etherscan-brownie
branch
from
0a298ba to
30333e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.