Split CompilationUnit into CompilationUnit + SourceUnit #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xalpharush
reviewed
Dec 12, 2022
crytic_compile/compilation_unit.py
Outdated
|
|
||
| def create_source_units(self, filename: Filename) -> SourceUnit: |
There was a problem hiding this comment.
I would rename this to make it clear it doesn't accept a list
Suggested change
| def create_source_units(self, filename: Filename) -> SourceUnit: | |
| def create_source_unit(self, filename: Filename) -> SourceUnit: |
|
This is missing #309 |
Rename create_source_units -> create_source_unit
|
Note: the CI failed because of #327 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP to stress test through the CI