Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: replace pysha3 with pycryptodome #309

Merged
merged 1 commit into from
Nov 14, 2022
Merged

deps: replace pysha3 with pycryptodome #309

merged 1 commit into from
Nov 14, 2022

Conversation

elopez
Copy link
Member

@elopez elopez commented Nov 14, 2022

pysha3 is unmaintained and does not build on Python 3.11

pysha3 is unmaintained and does not build on Python 3.11
@elopez elopez marked this pull request as ready for review November 14, 2022 12:47
@montyly montyly merged commit 6a92e37 into master Nov 14, 2022
@elopez elopez deleted the dev-remove-pysha3 branch November 14, 2022 13:27
@ekilmer
Copy link

ekilmer commented Jan 16, 2023

@elopez I'm curious why pycryptodome was chosen. Is there any benefit over using hashlib from standard Python? The pysha3 documentation states that hashlib is preferred (under Usage section) for Python 3.6+

The hashlib module of Python 3.6 will support the four SHA-3 algorithms and the two SHAKE algorithms on all platforms. Therefore you shouldn’t use the sha3 module directly and rather go through the hashlib interface:

@elopez
Copy link
Member Author

elopez commented Jan 16, 2023

Hi @ekilmer, we went with pycryptodome because hashlib did not offer keccak256 (the one used in ethereum) -- they only have the standardised sha3

@ekilmer
Copy link

ekilmer commented Jan 16, 2023

Ah! I did not realize there was an appreciable difference between the standardized sha3 and keccak256! Thank you for the explanation 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants