Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout overview page for mobile #155

Merged
merged 4 commits into from
Oct 6, 2023
Merged

Conversation

dreacot
Copy link
Member

@dreacot dreacot commented Oct 6, 2023

closes #125

This MR lays out the overview page for mobile, it does not include api/live data implementations, those would be broken down into different PRs. also the desktop is yet to implement live data for some cards, once those are done there would be follow up issues to populate the cards respective cards. The aim of this PR is simply to provide overview layout for the mobile apps

@dreacot
Copy link
Member Author

dreacot commented Oct 6, 2023

@Sirmorrison pointed out an issue with the asset balance slider #118 (comment) that causes the radius to look weird

Copy link
Collaborator

@JoeGruffins JoeGruffins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well for me on android.

@JoeGruffins
Copy link
Collaborator

@Sirmorrison pointed out an issues with the asset balance slider #118 (comment) that causes the radius to look weird

Also cannot flick the slider to see other coins.

@dreacot
Copy link
Member Author

dreacot commented Oct 6, 2023

@Sirmorrison pointed out an issues with the asset balance slider #118 (comment) that causes the radius to look weird

Also cannot flick the slider to see other coins.

Actually the slider shows the total balance for all asset type, e.g (if you have 3 dcr wallets, it sums up the balance and displays on the dcr asset slider, if you have no other btc/ltc, you won't see the sliders for btc/ltc).

But if you're referring to a fluid transition between sliders, when you flick them, then yes, that would make a lot of sense and would be desirable. We opted not to implement that initially for simplicity.

But I'd create an issue so the sliders can be enhanced

@dreacot dreacot merged commit 6a5bec4 into crypto-power:master Oct 6, 2023
1 check passed
@dreacot dreacot deleted the overview_page branch October 6, 2023 16:52
@dreacot
Copy link
Member Author

dreacot commented Oct 6, 2023

@Sirmorrison pointed out an issue with the asset balance slider #118 (comment) that causes the radius to look weird

this is the issue in question #140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mobile]: implement the overview page design
2 participants