Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overview Slider image Size Bug #140

Closed
Sirmorrison opened this issue Oct 2, 2023 · 2 comments · Fixed by #236
Closed

Overview Slider image Size Bug #140

Sirmorrison opened this issue Oct 2, 2023 · 2 comments · Fixed by #236
Assignees
@JustinBeBoy
Labels
bug Something isn't working

Comments

@Sirmorrison
Copy link
Collaborator

Currently, on the overview coin slider image layout looks like this.
image

A fix I will like to recommend will be for the coin image to be wrapped by a card or linearLayout that way, regardless of the image size, the image adoptes the size of what ever layout it is in.

Right now, the image is extending beyond the layout it is in.
@Sirmorrison Sirmorrison mentioned this issue Oct 2, 2023
Merged
@dreacot dreacot added the bug Something isn't working label Oct 2, 2023
@dreacot dreacot mentioned this issue Oct 6, 2023
Merged
@JoeGruffins
Copy link
Collaborator

What should it look like? A rectangle? Or should the edges be round like on the left? Rounder?

@dreacot
Copy link
Member

dreacot commented Oct 25, 2023

this is what it should look like

Image

@JustinBeBoy JustinBeBoy self-assigned this Nov 1, 2023
@JustinBeBoy JustinBeBoy mentioned this issue Nov 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JustinBeBoy JustinBeBoy

Labels
bug Something isn't working
Projects
dev
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Background image on Overview page JustinBeBoy/cryptopower
4 participants
@JustinBeBoy @dreacot @Sirmorrison @JoeGruffins