Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: no command to enable/disable bridge #775

Merged

Conversation

thomas-nguy
Copy link
Collaborator

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@thomas-nguy thomas-nguy requested a review from a team as a code owner November 23, 2022 02:33
@thomas-nguy thomas-nguy requested review from yihuang and devashishdxt and removed request for a team November 23, 2022 02:33
@thomas-nguy thomas-nguy marked this pull request as draft November 23, 2022 02:34
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #775 (499ecb4) into main (c9789da) will decrease coverage by 0.88%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #775      +/-   ##
==========================================
- Coverage   34.87%   33.99%   -0.89%     
==========================================
  Files          28       28              
  Lines        1468     1506      +38     
==========================================
  Hits          512      512              
- Misses        903      941      +38     
  Partials       53       53              
Impacted Files Coverage Δ
x/cronos/handler.go 86.95% <0.00%> (-13.05%) ⬇️
x/cronos/keeper/msg_server.go 3.57% <0.00%> (-0.98%) ⬇️
x/cronos/types/events.go 0.00% <ø> (ø)
x/cronos/types/messages.go 17.54% <0.00%> (-4.44%) ⬇️

Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not fully related to this, but made me think so, as it changes the proto file: @yihuang should the proto files be versioned now, given Cronos is v1?)

@thomas-nguy thomas-nguy marked this pull request as ready for review November 24, 2022 06:17
@thomas-nguy thomas-nguy force-pushed the thomas/turn-bridge-cmd branch from f4aa5da to fb986d3 Compare November 24, 2022 06:17
@yihuang
Copy link
Collaborator

yihuang commented Nov 24, 2022

(not fully related to this, but made me think so, as it changes the proto file: @yihuang should the proto files be versioned now, given Cronos is v1?)

yeah, sounds good.

Copy link
Collaborator

@yihuang yihuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomas-nguy
Copy link
Collaborator Author

protobuf check because of missing deps

Failure: buf.build/googleapis/googleapis:80720a488c9a414bb8d4a9f811084989: does not exist

any idea @yihuang ?

@thomas-nguy thomas-nguy force-pushed the thomas/turn-bridge-cmd branch from fb986d3 to 499ecb4 Compare December 5, 2022 05:16
@thomas-nguy thomas-nguy enabled auto-merge (squash) December 5, 2022 05:17
@thomas-nguy thomas-nguy merged commit be8d53d into crypto-org-chain:main Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants