-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: no command to enable/disable bridge #775
Problem: no command to enable/disable bridge #775
Conversation
Codecov Report
@@ Coverage Diff @@
## main #775 +/- ##
==========================================
- Coverage 34.87% 33.99% -0.89%
==========================================
Files 28 28
Lines 1468 1506 +38
==========================================
Hits 512 512
- Misses 903 941 +38
Partials 53 53
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(not fully related to this, but made me think so, as it changes the proto file: @yihuang should the proto files be versioned now, given Cronos is v1?)
f4aa5da
to
fb986d3
Compare
yeah, sounds good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
protobuf check because of missing deps
any idea @yihuang ? |
fb986d3
to
499ecb4
Compare
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)