-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: v1.0.x changes are not merged into main #816
Conversation
…rg-chain#696) * Problem: json-rpc apis fail for legacy blocks Solution: - keep the query handler in cosmos-sdk backward-compatible - add integration test to check * update sdk to upstream * ibc-go to rc2
…rypto-org-chain#703) (crypto-org-chain#705) * Problem: file changes detection in workflow is problematic Solution: - fix wildcards according the plugin's doc - reformat python * fix py-lint
…rypto-org-chain#713) (crypto-org-chain#719) * Problem: after v0.9.0 upgrade eth_call failed on old blocks Solution: - make grpc query compatible with old format * debug * fix eth_call * fix gravity upgrade test * update ethermint to main branch * update sdk
…n#702) (crypto-org-chain#721) Solution: - integration the basic file streamer * add integration test * changelog * fix build * fix lint * fix deliver tx event in cosmos-sdk * fix integration test * Update integration_tests/test_streamer.py Signed-off-by: yihuang <[email protected]> * update ethermint and fix build * add a small cli utility into test_streamer.py * fix integration test * update sdk to upstream Signed-off-by: yihuang <[email protected]> Signed-off-by: yihuang <[email protected]>
…org-chain#714) (crypto-org-chain#720) * Problem: new iavl indexes migration is slow and not optional Closes: crypto-org-chain#712 Solution: - Integrate the option introduced in cosmos-sdk * Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> Signed-off-by: yihuang <[email protected]> Signed-off-by: yihuang <[email protected]>
) (crypto-org-chain#730) * Problem: recent dependencies are not used (backport crypto-org-chain#729) Solution: - update cosmos-sdk to 0.46.2, ibc-go to v5.0.0, ethermint to recent main branch Update highlights: - new flag to disable fast node migration - fix streaming listeners bug - fix grpc server panic - fix index-eth-tx error on empty db * Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> Signed-off-by: yihuang <[email protected]>
…ted (crypto-org-chain#748) * Problem: chain state is inconsistent if upgrade migration is interrupted Solution: - update cosmos-sdk with the fix * Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> * gomod2nix * skip streamer test Signed-off-by: yihuang <[email protected]>
…ain#752) * Problem: recent fixes in dependencies are not included Solution: - update cosmos-sdk and iavl * Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> * fix build Signed-off-by: yihuang <[email protected]>
Solution: - revert the changes in ethermint
… query (crypto-org-chain#761) * Problem: evm execute result is non-deterministic with concurrent grpc query Solution: - update dependencies to include the fix * Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> * Update go.mod Signed-off-by: yihuang <[email protected]> Signed-off-by: yihuang <[email protected]>
…chain#762) * Problem: extra_eips is not cleared on production network Closes: crypto-org-chain#755 Solution: - add 1.0.0 upgrade plan to clear it * Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> * Update integration_tests/test_upgrade.py Signed-off-by: yihuang <[email protected]> * fix integration test Signed-off-by: yihuang <[email protected]>
…crypto-org-chain#763) * Problem: no error log when iavl set failure trigger app hash mismatch Solution: - log the error in cosmos-sdk * Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> * PR merged Signed-off-by: yihuang <[email protected]>
…rypto-org-chain#764) * Problem: different result from eth_getProof comparing with Ethereum Solution: - cherry-pick solution from ethermint, thanks @mmsqe * Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> Signed-off-by: yihuang <[email protected]>
…rypto-org-chain#766) (crypto-org-chain#768) Solution: - configure access-token - update the action plugins
* Problem: fixes in ibc-go v5.1 are not included Solution: - make a breaking change to upgrade to ibc-go `v5.1.0`. - will do v1.0.0 upgrade on both testnet and mainnet. * Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> * fix lint * include cache fix in tendermint * update sdk * Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> * Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> * make different plan name v1.0.0-testnet3 for testnet3 Signed-off-by: yihuang <[email protected]> Co-authored-by: mmsqe <[email protected]>
* fix upgrade set parameters * changelog
…ain#772) * Problem: formal v0.46.5 cosmos-sdk release is not used Solution: - update dependency, should be non-breaking for cronos * Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> * update to v0.46.6 Signed-off-by: yihuang <[email protected]>
Solution: - update changelog
) (crypto-org-chain#782) Solution: - add to root cmd
* Problem: cosmos-sdk `v0.46.7` is not used Solution: - update dependency - `v0.46.7` fix a gov migration issue which affect query votes of old proposals. * Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> * use sdk streamers config * fix streamer test * fix file streamer integration test * changelog Signed-off-by: yihuang <[email protected]>
* Problem: discontinued ibc-go version Solution: - update ibc-go to v5.2.0. - do another coordinated upgrade on testnet3. * Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> * Update app/upgrades.go Signed-off-by: yihuang <[email protected]> Signed-off-by: yihuang <[email protected]>
…chain#813) * Problem: production rocksdb configuration is not optimal Solution: - update related dependencies to allow customize rocksdb options. - especially using rocksdb v7. - tune rocksdb options. * Update Makefile Signed-off-by: yihuang <[email protected]> * remove rocksdb from niv * rocksdb options * update flake * fix build * create_if_missing * OptimizeLevelStyleCompaction and IncreaseParallelism * remove SetLevelCompactionDynamicLevelBytes and add BlockCache * fix integration test * comments Signed-off-by: yihuang <[email protected]>
* Problem: prometheus metrics is lost Solution: - setup correctly in ethermint * changelog
Signed-off-by: yihuang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #816 +/- ##
==========================================
- Coverage 34.26% 33.89% -0.37%
==========================================
Files 30 30
Lines 1582 1599 +17
==========================================
Hits 542 542
- Misses 983 1000 +17
Partials 57 57
|
I guess for the next time, it'll be better to first patch on main and then backport to release branches: https://trunkbaseddevelopment.com/branch-for-release/ ? |
For many changes, they need to be tested on testnet/mainnet first, but main branch is consensus breaking, thus current workflow. |
I guess some changes such as dependencies upgrades and bugfix could be done & tested on main first and then cherrypicked to release branches for patches specific to release branch, some may not even need to be rebased on main |
Co-authored-by: mmsqe <[email protected]> Signed-off-by: yihuang <[email protected]>
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)