Problem: iavl v1 pruning takes a long time #1692
Conversation
Solution: - set async pruning option
yihuang
requested review from
devashishdxt and
leejw51crypto
and removed request for
a team
WalkthroughThe pull request includes updates to the Changes
Possibly related PRs
Suggested reviewers
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 golangci-lintlevel=warning msg="The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar." 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Signed-off-by: yihuang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1692 +/- ##
===========================================
+ Coverage 16.87% 31.19% +14.31%
===========================================
Files 72 120 +48
Lines 6163 11718 +5555
===========================================
+ Hits 1040 3655 +2615
- Misses 5000 7731 +2731
- Partials 123 332 +209 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
go.mod (2)
Line range hint
3-3: Invalid Go version specifiedThe Go version
1.23.1does not exist. The latest stable version is1.22.1. This will cause build failures.Apply this diff to fix the version:
-go 1.23.1 +go 1.22
Line range hint
275-277: Track security-related TODOsThere are multiple TODO comments referencing security-related issues that need tracking:
- Removal of deprecated
jwt-gopackage- Fixing upstream vulnerabilities in
gin-gonic/ginWould you like me to create GitHub issues to track these security-related TODOs?
Also applies to: 279-280
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)go.mod(1 hunks)
🔇 Additional comments (3)
go.mod (2)
Line range hint 108-108: Verify IAVL version compatibility with async pruning
The IAVL version is pinned to a specific commit from the release/v1.2.x branch. Let's verify if this version includes the async pruning feature.
257-257: Verify Cosmos SDK fork compatibility
The PR updates to a specific commit of the crypto-org-chain's Cosmos SDK fork. Let's verify the changes in this fork.
✅ Verification successful
Cosmos SDK fork compatibility confirmed
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check the changes in the Cosmos SDK fork
# Get the commit message and changes
gh api \
-H "Accept: application/vnd.github+json" \
repos/crypto-org-chain/cosmos-sdk/commits/e790d2346678 \
--jq '.commit.message'
# Check for breaking changes
rg -l "BREAKING CHANGE"
Length of output: 487
Script:
#!/bin/bash
# Description: Check for indicators of breaking changes in the Cosmos SDK fork commit
# Search the commit message for 'BREAKING CHANGE' or similar indicators
gh api \
-H "Accept: application/vnd.github+json" \
repos/crypto-org-chain/cosmos-sdk/commits/e790d2346678 \
--jq '.commit.message' | rg -i "BREAKING CHANGE|significant change|major update"
Length of output: 183
CHANGELOG.md (1)
14-14: LGTM!
The changelog entry is well-formatted, correctly references PR #1692, and accurately describes the change to implement async pruning for IAVL v1.
yihuang
force-pushed
the
async-pruning
branch
2 times, most recently
from
5554c85
to
bb41758
Compare
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)
Summary by CodeRabbit
Bug Fixes
Improvements
NewKVStorenow accepts a string as the store name in versiondb.Documentation