-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ethermint v0.7.1 #169
Bump ethermint v0.7.1 #169
Conversation
c9e695a
to
a4f2a75
Compare
Codecov Report
@@ Coverage Diff @@
## main #169 +/- ##
==========================================
+ Coverage 21.51% 26.42% +4.90%
==========================================
Files 27 34 +7
Lines 1729 2426 +697
==========================================
+ Hits 372 641 +269
- Misses 1324 1737 +413
- Partials 33 48 +15
Continue to review full report at Codecov.
|
still having issue to update gomod2nix with my vpn |
One idea is we can change the workflow to upload the artifact when dirty, similar to this: https://github.com/crypto-org-chain/cronos/blob/main/.github/workflows/test.yml#L28. So you can download the generated file and commit again. |
go.mod
Outdated
@@ -41,5 +41,5 @@ replace github.com/peggyjv/gravity-bridge/module => github.com/crypto-org-chain/ | |||
|
|||
replace github.com/cosmos/iavl => github.com/cosmos/iavl v0.17.1 | |||
|
|||
// FIXME: https://github.com/crypto-org-chain/ethermint/tree/cronos2 | |||
replace github.com/tharsis/ethermint => github.com/crypto-org-chain/ethermint v0.4.2-0.20211004101819-7b5449f36cc8 | |||
replace github.com/tharsis/ethermint => github.com/crypto-org-chain/ethermint v0.7.1-patched |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems the only change is https://github.com/crypto-org-chain/ethermint/commits/thomas/v0.7.1-patched the go-ethereum -- I think that isn't needed, it's enough just to have the line to replace go-ethereum here (it'd use it in all dependencies, i.e. it's fine to use github.com/tharsis/ethermint without replacing ethermint)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, updated
a4f2a75
to
eeaf188
Compare
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
Bump ethermint version
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)