-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: websocket refactoring not used #1239
Conversation
Solution: - use the recent websocket/filter system refactoring in ethermint.
WalkthroughThe recent updates include a significant refactoring of the websocket/subscription system to improve performance and stability. Additionally, there's an adjustment to the gas requirements in a relayer precompile to better match actual usage. A test case in the integration tests has been simplified by removing a flaky decorator, and there's a shift in the RPC API implementation from using CometBFT to Ethermint's streaming service. Changes
Poem
TipsChat with CodeRabbit Bot (
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1239 +/- ##
===========================================
+ Coverage 16.67% 36.89% +20.22%
===========================================
Files 79 115 +36
Lines 5786 10255 +4469
===========================================
+ Hits 965 3784 +2819
- Misses 4743 6097 +1354
- Partials 78 374 +296
|
…d in next call" This reverts commit 6910f84.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files ignored due to filter (3)
- go.mod
- go.sum
- gomod2nix.toml
Files selected for processing (3)
- CHANGELOG.md (1 hunks)
- integration_tests/test_subscribe.py (2 hunks)
- x/cronos/rpc/api.go (3 hunks)
Files skipped from review due to trivial changes (1)
- integration_tests/test_subscribe.py
Additional comments: 3
x/cronos/rpc/api.go (3)
8-13: The import statement for "github.com/cometbft/cometbft/rpc/core/types" has been removed. Verify that this dependency is no longer required and that no code in this file or project relies on it.
18-24: The import statement for "github.com/evmos/ethermint/rpc/stream" has been added. Ensure that all references to the old websocket client have been updated to use the new stream client.
42-46: The signature of
CreateCronosRPCAPIs
has been changed to accept a*stream.RPCStream
instead of*rpcclient.WSClient
. Ensure that all invocations of this function have been updated accordingly and that the newRPCStream
is being used correctly within the function.
54e4d9c
* Problem: websocket refactoring not used Solution: - use the recent websocket/filter system refactoring in ethermint. * update ethermint * update filter offset to latest so only new changes are fetched in next call * fix filter * Revert "update filter offset to latest so only new changes are fetched in next call" This reverts commit 6910f84. * changelog --------- Co-authored-by: mmsqe <[email protected]>
* Problem: websocket refactoring not used (backport #1239) * Problem: websocket refactoring not used Solution: - use the recent websocket/filter system refactoring in ethermint. * update ethermint * update filter offset to latest so only new changes are fetched in next call * fix filter * Revert "update filter offset to latest so only new changes are fetched in next call" This reverts commit 6910f84. * changelog --------- Co-authored-by: mmsqe <[email protected]> * changelog --------- Co-authored-by: mmsqe <[email protected]>
* Problem: websocket refactoring not used Solution: - use the recent websocket/filter system refactoring in ethermint. * update ethermint * update filter offset to latest so only new changes are fetched in next call * fix filter * Revert "update filter offset to latest so only new changes are fetched in next call" This reverts commit 6910f84. * changelog --------- Co-authored-by: mmsqe <[email protected]>
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)
Summary by CodeRabbit
Refactor
Tests
Documentation