-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: ica in ibc v7.2.0 is not adjust correctly #1165
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1165 +/- ##
==========================================
+ Coverage 33.53% 34.01% +0.48%
==========================================
Files 113 112 -1
Lines 11076 11051 -25
==========================================
+ Hits 3714 3759 +45
+ Misses 6990 6914 -76
- Partials 372 378 +6
|
mmsqe
force-pushed
the
icaauth_route
branch
from
September 14, 2023 14:27
23a7e51
to
9d746f6
Compare
mmsqe
changed the title
Problem: icaauth route is not registered correctly
Problem: ica in ibc v7.2.0 is not adjust correctly
Sep 14, 2023
mmsqe
requested review from
yihuang and
leejw51crypto
and removed request for
a team
September 14, 2023 14:31
@@ -79,7 +66,7 @@ | |||
// timeoutDuration should be constraited by MinTimeoutDuration parameter. | |||
timeoutTimestamp := ctx.BlockTime().Add(timeoutDuration).UnixNano() | |||
|
|||
_, err = k.icaControllerKeeper.SendTx(ctx, channelCapability, connectionID, portID, packetData, uint64(timeoutTimestamp)) //nolint:staticcheck | |||
_, err = k.icaControllerKeeper.SendTx(ctx, nil, connectionID, portID, packetData, uint64(timeoutTimestamp)) //nolint:staticcheck |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion Error
Potential integer overflow by integer type conversion
mmsqe
commented
Sep 14, 2023
mmsqe
force-pushed
the
icaauth_route
branch
from
September 14, 2023 15:40
0be27d7
to
ee17511
Compare
yihuang
approved these changes
Sep 15, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 15, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 15, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 15, 2023
Merged
via the queue into
crypto-org-chain:main
with commit Sep 15, 2023
6935b19
22 of 24 checks passed
13 tasks
This was referenced Apr 26, 2024
This was referenced Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)