Problem: not using the latest SDK pre-release #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomtau
requested review from
calvinaco,
devashishdxt,
leejw51crypto,
linfeng-crypto and
yihuang
as code owners
|
/runsim |
|
Simulation tests started and triggered by |
Codecov Report
@@ Coverage Diff @@
## master #341 +/- ##
=======================================
Coverage 10.25% 10.26%
=======================================
Files 35 35
Lines 5351 5349 -2
=======================================
Hits 549 549
+ Misses 4649 4648 -1
+ Partials 153 152 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
yihuang
reviewed
Jan 5, 2021
tomtau
force-pushed
the
update/rc6
branch
2 times, most recently
from
1632882
to
0bdc23b
Compare
yihuang
approved these changes
Jan 5, 2021
|
✅ |
|
will reopen when this gets resolved: cosmos/cosmos-sdk#8251 as it breaks the integration tests |
diff --git a/integration_tests/test_upgrade.py b/integration_tests/test_upgrade.py
index e292efa..1fe498f 100644
--- a/integration_tests/test_upgrade.py
+++ b/integration_tests/test_upgrade.py
@@ -16,6 +16,7 @@ from .utils import (
parse_events,
wait_for_block,
wait_for_block_time,
+ wait_for_new_blocks,
wait_for_port,
)
@@ -171,6 +172,8 @@ def test_manual_upgrade(cosmovisor_cluster):
cluster.reload_supervisor()
time.sleep(5) # FIXME the port seems still exists for a while after process stopped
wait_for_port(rpc_port(cluster.config["validators"][0]["base_port"]))
+ # wait for a new block to make sure chain started up
+ wait_for_new_blocks(cluster, 1)
target_height = cluster.block_height() + 15
print("upgrade height", target_height) |
Solution: bumped the dependencies to rc6 + workaround for gentx in integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: bumped the dependencies to rc6