Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gentx denomination is ignored (default "stake" is used instead) #8251

Closed
4 tasks
tomtau opened this issue Jan 5, 2021 · 4 comments · Fixed by #8255
Closed
4 tasks

gentx denomination is ignored (default "stake" is used instead) #8251

tomtau opened this issue Jan 5, 2021 · 4 comments · Fixed by #8255
Assignees
Labels
C:CLI C:x/genutil genutil module issues T:Bug

Comments

@tomtau
Copy link
Contributor

tomtau commented Jan 5, 2021

Summary of Bug

After #8183

The generated tx using BuildCreateValidatorMsg won't use the amount provided in args[1], but will use createValCfg.Amount. The written gentx won't use the provided denomination (e.g. "uatom"), but will just use "stake".

Version

v0.40.0-rc6

Steps to Reproduce

  1. run gentx [name] [amountStr where denom isn't "stake"]
  2. check the written tx

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@RiccardoM
Copy link
Contributor

RiccardoM commented Jan 5, 2021

I've tried this as well, and it seems that there still is an --amount flag inside this command. If you provide the same amount inside the second argument and the flag, it will work:

gentx [name] 100000uatom --amount 100000uatom

I don't think this was intended, as it seems to me like a strange workaround.

@tomtau
Copy link
Contributor Author

tomtau commented Jan 5, 2021

I've tried this as well, and it seems that there still is an --amount flag inside this command. If you provide the same amount inside the second argument and the flag, it will work:

gentx [name] 100000uatom --amount 100000uatom

I don't think this was intended, as it seems to me like a strange workaround.

Yes, the double amount workaround works

@amaury1093
Copy link
Contributor

Yes, reproduced too. @tomtau or @RiccardoM did any one of you start looking at a fix? If not, I can have a look today.

@amaury1093 amaury1093 added T:Bug C:CLI C:x/genutil genutil module issues labels Jan 5, 2021
@RiccardoM
Copy link
Contributor

Yes, reproduced too. @tomtau or @RiccardoM did any one of you start looking at a fix? If not, I can have a look today.

I did not

@amaury1093 amaury1093 self-assigned this Jan 5, 2021
@amaury1093 amaury1093 added this to the v0.40 [Stargate] milestone Jan 5, 2021
@mergify mergify bot closed this as completed in #8255 Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:CLI C:x/genutil genutil module issues T:Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants