Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to cosmos-sdk v0.40.0-rc6 #354

Merged
merged 3 commits into from
Jan 6, 2021
Merged

Upgrade to cosmos-sdk v0.40.0-rc6 #354

merged 3 commits into from
Jan 6, 2021

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Jan 5, 2021 •
edited
Loading

Upgrade to cosmos-sdk v0.40.0-rc6

There is a known 🐛 #8251 with this SDK version in the gentx CLI command. The workaround is documented in the issue as well:

# pass the staked amount as argument AND as parameter
wasmd gentx validator "250000000$STAKE" --chain-id="$CHAIN_ID" --amount="250000000$STAKE"

@codecov
Copy link

codecov bot commented Jan 5, 2021 •
edited
Loading

Codecov Report

Merging #354 (17c05e2) into master (e8d26c7) will decrease coverage by 0.54%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #354      +/-   ##
==========================================
- Coverage   69.73%   69.18%   -0.55%     
==========================================
  Files          28       28              
  Lines        2425     2379      -46     
==========================================
- Hits         1691     1646      -45     
+ Misses        617      616       -1     
  Partials      117      117
Impacted Files Coverage Δ
x/wasm/internal/types/test_fixtures.go 96.20% <0.00%> (-0.60%) ⬇️

This was referenced Jan 5, 2021
Closed
Closed
Closed
Closed
@alpe alpe added the stargate label Jan 5, 2021
ethanfrey
ethanfrey approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff.
Not sure how to document the client changes (diff staking args).

Maybe a little changelog entry?

contrib/local/setup_wasmd.sh Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
x/wasm/internal/keeper/staking_test.go Show resolved Hide resolved
@ethanfrey ethanfrey mentioned this pull request Jan 5, 2021
Closed
@alpe alpe marked this pull request as ready for review January 6, 2021 09:02
@alpe
Copy link
Contributor Author

alpe commented Jan 6, 2021

I had added CosmWasm/docs#128 to update the docs

@alpe alpe merged commit 447fb07 into master Jan 6, 2021
@alpe alpe deleted the sdk-upgrade-rc6 branch January 6, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 left review comments

@ethanfrey ethanfrey ethanfrey approved these changes

Assignees
No one assigned
Labels
stargate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alpe @webmaster128 @ethanfrey