Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(gameserver): add gameserver test application #2

Merged
merged 4 commits into from
Jul 6, 2024

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Jul 4, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


See cryostatio/cryostat#402 for this image being deployed alongside Cryostat

Description of the change:

This change allows an environment variable to be configured so that...

Motivation for the change:

This change is helpful because users may want to...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... bash smoketest.bash...
  2. ...

@andrewazores
Copy link
Member Author

This should be buildable using build.bash, and testing that it starts up and the Agent connects using cryostatio/cryostat#402 should be straightforward. Actually getting a game client to connect to the server instance is a bit different since the official game clients require an account signup and things, but there are third party launchers that allow connecting to custom servers without an account. Drop me a message if you'd like some direction on how to accomplish that, but this is only really needed if you want to try to generate some activity and additional JFR data. Even without connecting a game client, the target should appear in Cryostat and there should be data to gather.

@andrewazores andrewazores merged commit 243e64e into cryostatio:main Jul 6, 2024
1 check passed
@andrewazores andrewazores deleted the gameserver branch July 6, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants