Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(smoketest): use test-applications sample apps #402

Merged
merged 13 commits into from
Jul 8, 2024

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Apr 23, 2024

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #403

Description of the change:

This change allows an environment variable to be configured so that...

Motivation for the change:

This change is helpful because users may want to...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... bash smoketest.bash...
  2. ...

@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Apr 23, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

2 similar comments
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@andrewazores andrewazores removed the needs-triage Needs thorough attention from code reviewers label Apr 23, 2024
@andrewazores andrewazores changed the title test(smoketest): add additional testing sample app test(smoketest): use test-applications sample apps Jul 4, 2024
@andrewazores andrewazores marked this pull request as ready for review July 6, 2024 01:58
@andrewazores
Copy link
Member Author

/build_test

@andrewazores andrewazores requested review from aali309 and mwangggg July 6, 2024 01:58
Copy link

github-actions bot commented Jul 6, 2024

Workflow started at 7/5/2024, 9:58:35 PM. View Actions Run.

Copy link

github-actions bot commented Jul 6, 2024

No OpenAPI schema changes detected.

Copy link

github-actions bot commented Jul 6, 2024

No GraphQL schema changes detected.

Copy link

github-actions bot commented Jul 6, 2024

CI build and push: All tests pass ✅ (JDK17)
https://github.com/cryostatio/cryostat/actions/runs/9815672881

aali309
aali309 previously approved these changes Jul 8, 2024
Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@andrewazores andrewazores merged commit 3319559 into cryostatio:main Jul 8, 2024
7 of 8 checks passed
@andrewazores andrewazores deleted the minecraft-sample branch July 8, 2024 21:20
mergify bot pushed a commit that referenced this pull request Jul 8, 2024
andrewazores added a commit that referenced this pull request Jul 8, 2024
)

test(smoketest): use test-applications sample apps (#402)

(cherry picked from commit 3319559)

Co-authored-by: Andrew Azores <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants