chore(smoketest): clean up scripts for relative paths, shellcheck hints

[andrewazores]

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

• Read the contributing guidelines
• Linked a relevant issue which this PR resolves
• Linked any other relevant issues, PR's, or documentation, if any
• Resolved all conflicts, if any
• Rebased your branch PR on top of the latest upstream main branch
• Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
• Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

---

Related to #35
Depends on #129

[github-actions]

This PR/issue depends on:

• feat(db): inherit from scl image, enforce PG_ENCRYPT_KEY #129
  By Dependent Issues (🤖). Happy coding!

[mwangggg]

Is there a reason for the change from generate.sh to generate.bash? Should smoketest.sh also be changed to smoketest.bash?

[andrewazores]

The .sh vs .bash extension change is just to better indicate what kind of script the file actually contains. Since the scripts rely on Bash-specific syntaxes they use (or should use) the #!/usr/bin/env bash shebang line to ensure that the script is interpreted using Bash, and including .bash as part of the filename just helps the reader to identify that, and may also be useful for syntax highlighting for editors for example.

Other scripts that use #!/usr/bin/sh and end in .sh can stay that way if they don't use Bash-specific syntax extensions on top of what POSIX sh implements, or they can be "upgraded" to use Bash even if they don't use any Bash-specific syntaxes. Maybe for consistency/simplicity I'll change all scripts to specify Bash.

[mwangggg]

I think the smoketesting for k8s section in README.md will also need to be upated with bash smoketest.bash now

[mwangggg]

I think after the db entrypoint was changed in #129, the entrypoint in db_k8s.yml needs to be updated

[andrewazores]

I'll fix that in #136

[mwangggg]

lgtm