Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(smoketest): update minio healthcheck to not require 'curl' in container #138

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Nov 1, 2023

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #137
Based on #131
Depends on #131

@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Nov 1, 2023
@andrewazores andrewazores added test and removed needs-triage Needs thorough attention from code reviewers labels Nov 1, 2023
Copy link

github-actions bot commented Nov 1, 2023

This PR/issue depends on:

@mwangggg
Copy link
Member

mwangggg commented Nov 2, 2023

Screenshot from 2023-11-02 14-16-44
not sure why this is happening?

@andrewazores
Copy link
Member Author

It looks like the problem there is that it's trying to run all of mc ready local as a single command, rather than mc being the command and ready local being arguments to it. I'm not sure why that's happening for you and not for me, though. What were the steps you took to get to this?

@mwangggg
Copy link
Member

mwangggg commented Nov 2, 2023

kubectl describe pod $S3_POD

@andrewazores
Copy link
Member Author

And before that, was this just a normal smoketest.bash generate apply off of this PR branch?

@andrewazores
Copy link
Member Author

Latest commit should make it explicit that the healthcheck is a command followed by a series of arguments, not all somehow a single binary to execute. Either way works on my setup for whatever reason, so let me know if this fixes it on your setup.

@mwangggg
Copy link
Member

mwangggg commented Nov 2, 2023

that fixed it! not sure why it wasn't working before for my setup before but it's good now

@andrewazores andrewazores merged commit a63b2f8 into cryostatio:main Nov 2, 2023
8 checks passed
@andrewazores andrewazores deleted the minio-healthcheck branch November 2, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] smoketest failure due to Minio healthcheck unhealthy
2 participants