Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(db): update references to split-out database container #136

Merged
merged 11 commits into from
Nov 3, 2023

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Oct 31, 2023

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #132
Based on #131
Depends on #131

See https://github.com/cryostatio/cryostat-db
See https://quay.io/repository/cryostat/cryostat-db?tab=tags

@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Oct 31, 2023
@andrewazores andrewazores added chore Refactor, rename, cleanup, etc. and removed needs-triage Needs thorough attention from code reviewers labels Oct 31, 2023
@github-actions github-actions bot removed the dependent label Nov 1, 2023
Copy link

github-actions bot commented Nov 1, 2023

This PR/issue depends on:

@mwangggg
Copy link
Member

mwangggg commented Nov 1, 2023

is there any reason the namespace: default line in the files have been deleted? When I run bash smoketest.bash kind it gets readded...

@andrewazores
Copy link
Member Author

Hmm, that doesn't happen for me, and that change was just part of regenerating those files with bash smoketest/k8s/smoketest.bash generate.

I'm using a slightly older version of kompose, let me upgrade and see if that changes what it generates.

@mwangggg
Copy link
Member

mwangggg commented Nov 1, 2023

huh interesting... perhaps I also need to update kompose

mwangggg
mwangggg previously approved these changes Nov 1, 2023
Copy link
Member

@mwangggg mwangggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tthvo
Copy link
Member

tthvo commented Nov 1, 2023

Looks like the changelog explains it:

https://github.com/kubernetes/kompose/releases/tag/v1.31.2

Very nice since we can deploy with current namespace instead of default^^

@tthvo
Copy link
Member

tthvo commented Nov 1, 2023

Let's also update the kompose version requirement in README?

@andrewazores
Copy link
Member Author

@mwangggg @aali309 ping

@aali309
Copy link
Contributor

aali309 commented Nov 3, 2023

@mwangggg @aali309 ping

running tests

Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewazores andrewazores merged commit 3e7c6cc into cryostatio:main Nov 3, 2023
6 of 8 checks passed
@andrewazores andrewazores deleted the separate-db branch November 3, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Task] Split out database into separate repo
4 participants