Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agent): patch event should consider current target selection #904

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Mar 9, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

Fixes: #893

Description of the change:

Take into account the current global target selection when updating probe table.

Motivation for the change:

See #893

@tthvo tthvo added the fix label Mar 9, 2023
@tthvo tthvo requested review from andrewazores and maxcao13 March 9, 2023 22:54
@mergify mergify bot added the safe-to-test label Mar 9, 2023
@tthvo
Copy link
Member Author

tthvo commented Mar 9, 2023

Just a bit of hiccup here: #893 (comment)

But since switching target will eventually overwrite that incorrect intermediate state with correct information, we can leave it as it is?

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-904-3d411b6eafa10db46e7c6539d579873776af4f87 sh smoketest.sh

@andrewazores
Copy link
Member

Makes sense. There are probably similar examples like this elsewhere, too. I'll test this out soon to make sure it works as expected.

@andrewazores andrewazores merged commit 9cfd2ef into cryostatio:main Mar 10, 2023
@tthvo tthvo deleted the probe-notification branch March 10, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] Agent probe notification handler should check current target
2 participants