[Bug] Agent probe notification handler should check current target

[tthvo]

Current Behavior:

Agent Live Configuration table is updating with incorrect data (belonging to other targets).

Expected Behavior:

Agent Live Configuration table should just update its content on notification if the selected target is matched.

Source code

 React.useEffect(() => {
    addSubscription(
      // This will just apply without any knowledge of currently selected target
      context.notificationChannel.messages(NotificationCategory.ProbeTemplateApplied).subscribe((e) => {
        setProbes((old) => {
          const probes = e.message.events as EventProbe[];
          const probeIds = probes.map((p) => p.id);
          if (probes?.length > 0) {
            return [...old.filter((probe) => !probeIds.includes(probe.id)), ...probes];
          }
          return old;
        });
      })
    );
  }, [addSubscription, context, context.notificationChannel, setProbes]);

  React.useEffect(() => {
    addSubscription(
     // same here
      context.notificationChannel.messages(NotificationCategory.ProbesRemoved).subscribe((_) => setProbes([]))
    );
  }, [addSubscription, context, context.notificationChannel, setProbes]);

Others

Related to #709 (previously missing this check).

[tthvo]

While here, using only combineLatest as below, for example in active recording table:

  React.useEffect(() => {
    addSubscription(
      combineLatest([
        context.target.target(),
        merge(
          context.notificationChannel.messages(NotificationCategory.ActiveRecordingCreated),
          context.notificationChannel.messages(NotificationCategory.SnapshotCreated)
        ),
      ]).subscribe(([currentTarget, event]) => {
        if (currentTarget.connectUrl != event.message.target) {
          return;
        }
        setRecordings((old) => old.concat([event.message.recording]));
      })
    );
  }, [addSubscription, context, context.notificationChannel, setRecordings]);

This is not quite safe. If the context.target.target emits another value (changing global target selection), then outer observable will emit it along with the old event message.

I think we can fix with switchMap but its not too serious thanks to fetching new recordings (take some time). The state is correctly overwritten later on. Just intermediate states are incorrect.