feat(dashboard): add JVM Details card #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
force-pushed
the
jvm-details-dashboard-card
branch
from
9f15d13 to
e1df0ff
Compare
|
Test image available: |
|
I'll wait for yours and pull it out to a shared component. |
|
Test image available: |
andrewazores
force-pushed
the
jvm-details-dashboard-card
branch
from
2a0ffe2 to
54244ec
Compare
|
Test image available: |
|
Test image available: |
|
This PR/issue depends on:
|
andrewazores
force-pushed
the
jvm-details-dashboard-card
branch
from
557da7e to
206126e
Compare
|
|
|
Test image available: |
|
Test image available: |
andrewazores
force-pushed
the
jvm-details-dashboard-card
branch
2 times, most recently
from
108c8fc to
5c14705
Compare
|
No features for #895 right? |
|
I could (re)add that into the new shared component. |
|
Test image available: |
tthvo
reviewed
Mar 14, 2023
tthvo
reviewed
Mar 14, 2023
tthvo
reviewed
Mar 14, 2023
Sure! I think I have a const here to define them. I guess we can extract into a common function to return this array. |
|
Test image available: |
tthvo
reviewed
Mar 14, 2023
|
Test image available: |
|
Bah, I need to rebase to sign commits. |
Signed-off-by: Andrew Azores <[email protected]>
Signed-off-by: Andrew Azores <[email protected]>
Signed-off-by: Andrew Azores <[email protected]>
andrewazores
force-pushed
the
jvm-details-dashboard-card
branch
from
3d18ba0 to
70399a8
Compare
|
Test image available: |
maxcao13
approved these changes
Mar 15, 2023
tthvo
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]git commit --amend --signoffFixes: #894
Fixes: #895
Depends on #891
Description of the change:
This adds a simple dashboard card that simply displays basic information about the selected target JVM such as its connection URL, alias, and labels/annotations.
Motivation for the change:
This provides users with a nicer presentation of the data currently displayed on the
<TargetSelect/>component expansion, which the user might need to know in order to define matchExpression credentials, automated rules, or to filter/sort through the All Archives table. A follow-up PR will add further MBean-based information to this card as well.How to manually test: