Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): fix peer deps, upgrade react router #726

Closed
wants to merge 5 commits into from

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Dec 8, 2022

remix-run/react-router#8753

current state: deeps properly upgraded, application builds and works. tests very broken

@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Dec 8, 2022
@andrewazores andrewazores added chore Refactor, rename, cleanup, etc. build labels Dec 8, 2022
@tthvo
Copy link
Member

tthvo commented Oct 19, 2023

Hey @andrewazores, I am working on upgrading to React 18 for #1110. But run into lots of type issues:

Route' cannot be used as a JSX component.
  Its instance type 'Route<{}, string>' is not a valid JSX element.
    The types returned by 'render()' are incompatible between these types.
      Type 'import("/home/thvo/workspace/cryostat-web/node_modules/@types/react-router/node_modules/@types/react/index").ReactNode' is not assignable to type 'React.ReactNode'.ts(2786)

Might need to upgrade to Router v6 before that. Would u like me to continue this? Not sure if I can push to ur fork but I will open a new one with these commits.

@andrewazores
Copy link
Member Author

andrewazores commented Oct 19, 2023

Ah, that looks annoying. I haven't had time to look any deeper into this and see what the upgrade path looks like or what else may be involved, but if you're interested to continue working on this then I would really appreciate it. We're starting to fall fairly far behind on upgrading these fairly major dependencies.

@tthvo
Copy link
Member

tthvo commented Oct 19, 2023

Sounds good! Thanks! I will continuue on this.

@tthvo
Copy link
Member

tthvo commented Oct 21, 2023

Work continue on #1143.

@tthvo tthvo closed this Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build chore Refactor, rename, cleanup, etc. needs-triage Needs thorough attention from code reviewers safe-to-test
Projects
No open projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants