chore(recordings): remove subdirectory for jvmId in recording requests #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tthvo
reviewed
Oct 2, 2023
mwangggg
force-pushed
the
993-remove-subdirectory-archive
branch
2 times, most recently
from
c259066 to
9a7ad48
Compare
mwangggg
force-pushed
the
993-remove-subdirectory-archive
branch
from
6d91d25 to
9a7ad48
Compare
|
This PR/issue depends on:
|
mwangggg
force-pushed
the
993-remove-subdirectory-archive
branch
from
5469545 to
41c6eeb
Compare
|
/build_test |
|
Test image available: |
mwangggg
force-pushed
the
993-remove-subdirectory-archive
branch
2 times, most recently
from
3f15604 to
69aa679
Compare
|
huh after rebasing, it's failing 90% of tests when I run |
|
|
|
yea that fixed it - I think it was the |
7 tasks
mwangggg
force-pushed
the
993-remove-subdirectory-archive
branch
from
69aa679 to
a5ee6d7
Compare
andrewazores
approved these changes
Oct 30, 2023
andrewazores
pushed a commit
that referenced
this pull request
Oct 30, 2023
#1127) (#1150) (cherry picked from commit bf9af76) Co-authored-by: Ming Yu Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainFixes: #993
Depends on https://github.com/cryostatio/cryostat/pull/1692
Depends on https://github.com/cryostatio/cryostat/issues/1738