Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Remove any mentions of subdirectory names to use jvmId in "fromPath" requests #993

Closed
maxcao13 opened this issue Apr 25, 2023 · 0 comments · Fixed by #1127
Closed
Assignees
Labels
chore Refactor, rename, cleanup, etc. good first issue Good for newcomers

Comments

@maxcao13
Copy link
Member

maxcao13 commented Apr 25, 2023

Currently, to directly get archived recordings/labels from cryostat's file system, users have to supply a subdirectoryName, and a recordingName to either get/post/delete the report/recording/labels/grafana-report/ etc. depending on the request.

In the archives view, the web-client requests for an archivedDirectories get response returns the archives directory structure including the jvmId for each target subdirectory name, instead of the actual subdirectory name (which is just the base32 encoding of the jvmId in UTF_8 standard encoding), and the recordings in each target, and populates a table with this data.

This means that to do actions using this view, we need to supply a subdirectory name to the request, but since the web-client only knows about each target's jvmId, we currently use a util function to base32 encode the jvmId in the web-client itself and then send it over.

Instead of this extra encoding/decoding logic on both client and server, it is probably better to have all conversion processing on the server side, and only require jvmIds to be passed in and out of requests and responses to the cryostat backend, which means a little refactoring for each "fromPath" method handler.

@maxcao13 maxcao13 added good first issue Good for newcomers chore Refactor, rename, cleanup, etc. needs-triage Needs thorough attention from code reviewers labels Apr 25, 2023
@maxcao13 maxcao13 moved this to Todo in 2.4.0 release Apr 25, 2023
@tthvo tthvo removed the needs-triage Needs thorough attention from code reviewers label Apr 25, 2023
@andrewazores andrewazores moved this from Todo to Backlog in 2.4.0 release May 23, 2023
@andrewazores andrewazores moved this from Backlog to Stretch Goals in 2.4.0 release May 23, 2023
@mwangggg mwangggg self-assigned this Oct 2, 2023
@github-project-automation github-project-automation bot moved this from Stretch Goals to Done in 2.4.0 release Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. good first issue Good for newcomers
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants