-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(agent): add pod mutation webhook to inject agent #991
base: main
Are you sure you want to change the base?
Conversation
I added a config sample to do |
/build_test |
prefixWithKind := strings.ToLower(gvk.Kind) | ||
if short { | ||
// Prefix is 5 characters: 4 from kind, and hyphen | ||
prefixWithKind = prefixWithKind[:4] // TODO can we use a weaker and shorter hash and keep the full kind? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewazores what do you think about using a non-cryptographic hash function for this instead?
With https://pkg.go.dev/hash/fnv, we could use:
cryostat-<128-bit hash>
instead of cryo-<224-bit hash>
|
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
git commit -S -m "YOUR_COMMIT_MESSAGE"
Fixes: #970
Description of the change:
Motivation for the change:
How to manually test:
make deploy
make create_cryostat_cr
make sample_app
JAVA_OPTS_APPEND
to not inject the built-in Cryostat agent.I've filed issues for the TODOs in this PR. There are a few of them, but they're all pretty small compared to this PR:
#992, #993, #994, #995, #996