Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #312
AuthPostHandler
ClientUrlGetHandler
GrafanaDashboardUrlGetHandler
GrafanaDatasourceUrlGetHandler
RecordingDeleteHandler
RecordingGetHandler
ctx.vertx().filesystem().exists()
is async.RecordingsGetHandler
RecordingsPostHandler
validateRecording()
andsaveRecording()
are async, but this handler already hasisAsync()
set tofalse
.RecordingUploadPostHandler
isAsync()
set tofalse
.ReportGetHandler
isAsync()
set tofalse
.TargetEventsGetHandler
TargetRecordingDeleteHandler
TargetRecordingGetHandler
isAsync()
set tofalse
.TargetRecordingOptionsGetHandler
isAsync()
set tofalse
.TargetRecordingOptionsPatchHandler
TargetRecordingPatchHandler
isAsync()
set tofalse
.TargetRecordingsGetHandler
TargetRecordingsPostHandler
Already hasisAsync()
set tofalse
.TargetRecordingUploadPostHandler
isAsync()
set tofalse
.TargetReportGetHandler
isAsync()
set tofalse
.TargetsGetHandler
TargetSnapshotPostHandler
TargetTemplateGetHandler
TargetTemplatesGetHandler
TemplateDeleteHandler
TemplatesPostHandler
CertificatePostHandler
(V2)isAsync()
set tofalse
.TargetEventsSearchGetHandler
(V2)isAsync()
set tofalse
.TargetRecordingOptionsListGetHandler
(V2)isAsync()
set tofalse
.TargetSnapshotPostHandler
(V2)AuthPostHandler
,GrafanaDashboardUrlGetHandler
, andGrafanaDatasourceUrlGetHandler
are not async, but they're all simple handlers, so I've set theirisAsync()
values totrue
anyway, as suggested.ClientUrlGetHandler
doesn't seem to be async from what I can tell, but there's a unit test that expects it to be async, so I didn't change it.RecordingsPostHandler
seems to have async helper functions, but it already had itsisAsync()
set tofalse
, so I didn't change it.Edit:
TargetRecordingsPostHandler
didn't actually haveisAsync()
set tofalse
already, but it does appear to be synchronous.