You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The isAsync method on RequestHandlers returns true by default, but some handlers override this to return false. This value is used by the WebServer to determine how to install the handler into the Router - if isAsync == true then the handler is installed normally, otherwise it is installed as a blocking handler. Any handlers which are not themselves implemented async should have isAsync == false so that Vertx runs the handler on a separate worker thread (perhaps with some small exceptions like GrafanaDashboardUrlGetHandler which simply returns a String read from env).
The goal in investigating/fixing this issue is not to reimplement handlers to add/remove async pieces of their implementations but simply to check behaviours and update isAsync to match.
The text was updated successfully, but these errors were encountered:
#310 (review)
The
isAsync
method onRequestHandler
s returnstrue
by default, but some handlers override this to returnfalse
. This value is used by theWebServer
to determine how to install the handler into theRouter
- ifisAsync == true
then the handler is installed normally, otherwise it is installed as a blocking handler. Any handlers which are not themselves implemented async should haveisAsync == false
so that Vertx runs the handler on a separate worker thread (perhaps with some small exceptions likeGrafanaDashboardUrlGetHandler
which simply returns a String read from env).The goal in investigating/fixing this issue is not to reimplement handlers to add/remove async pieces of their implementations but simply to check behaviours and update
isAsync
to match.The text was updated successfully, but these errors were encountered: