Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate whether HTTP handlers are all correctly async #312

Closed
andrewazores opened this issue Oct 26, 2020 · 0 comments · Fixed by #378
Closed

Investigate whether HTTP handlers are all correctly async #312

andrewazores opened this issue Oct 26, 2020 · 0 comments · Fixed by #378
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@andrewazores
Copy link
Member

#310 (review)

The isAsync method on RequestHandlers returns true by default, but some handlers override this to return false. This value is used by the WebServer to determine how to install the handler into the Router - if isAsync == true then the handler is installed normally, otherwise it is installed as a blocking handler. Any handlers which are not themselves implemented async should have isAsync == false so that Vertx runs the handler on a separate worker thread (perhaps with some small exceptions like GrafanaDashboardUrlGetHandler which simply returns a String read from env).

The goal in investigating/fixing this issue is not to reimplement handlers to add/remove async pieces of their implementations but simply to check behaviours and update isAsync to match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants